Conversation
mawilk90
requested review from
ezilber-akamai and
yec-akamai
and removed request for
a team
There was a problem hiding this comment.
Pull request overview
This PR addresses regression issues in integration tests that were failing due to race conditions when resources (particularly Linodes) were not fully provisioned before being used in tests. The fixes primarily add wait_for_condition calls to ensure resources reach the expected state before proceeding with test operations.
Changes:
- Renamed helper function
create_linodetocreate_linode_functo avoid naming conflict with existing fixture - Added wait conditions to ensure Linodes are in expected states before performing operations
- Fixed import ordering to follow PEP 8 conventions
- Reordered domain test operations to ensure clone completes before verification
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test/integration/models/networking/test_networking.py | Renamed create_linode to create_linode_func to avoid fixture name collision; added wait conditions for Linode status in VLAN and IP info tests |
| test/integration/models/linode/test_linode.py | Added wait condition to verify Linode reaches offline status during migration before deletion |
| test/integration/models/domain/test_domain.py | Moved time.sleep(1) before fetching domains to ensure clone operation completes |
| test/integration/models/account/test_account.py | Fixed import ordering to follow PEP 8; added wait condition to ensure Linode is running before checking events |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
vshanthe
left a comment
vshanthe
left a comment
There was a problem hiding this comment.
LGTM , you can run make lint to fix lint issue
I did some investigation on it - failing linter is related to "isort" as I changed imports order in test_account.py. I changed that because "test" is not a standard library, but our internal package, so it should be imported as last acc. to PEP8. Unfortunately isort sees it as built-in library and wants to import it on the beginning -> error (I guess that folder name "test" is problematic - there is no issues for "tests"). For now, I reverted my changes on imports (lint passed). |
2 participants
📝 Description
Regression fixes for integration tests. Most of the failures were possibly related to long provisioning ([404] Not found)
Jira: https://track.akamai.com/jira/browse/TPT-4203
✔️ How to Test
Integration tests workflow run